Initialise locale formatting in advance as a performance improvement #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
May 7, 2024
There was a problem hiding this comment.
I think there's probably a good argument for designing this in such a way that breaks up and defers possible long tasks to idle time...but I'm on board with not overcomplicating it and erring strongly on the side of the extension not interfering with page performance
Co-authored-by: Brendan Kenny <[email protected]>
|
@brendankenny upon suggestion from @rviscomi I'm initialising the three formatters needed up front once, rather than each time the metric changes. As the extension is only initialised after the document is WDYT? |
tunetheweb
changed the title
tunetheweb
changed the title
brendankenny
approved these changes
May 8, 2024
tunetheweb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue raised in #178 (comment)
This initialised the formatters once as the extension is initialised, rather than with each metric update for a god performance improvement, but also allows us to keep the INTL option.